Skip to content

Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, tuirec GIF docs, and cleanup pass#5394

Closed
Copilot wants to merge 6 commits into
developfrom
copilot/add-terminal-gui-interop-spectre-bridge-package
Closed

Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, tuirec GIF docs, and cleanup pass#5394
Copilot wants to merge 6 commits into
developfrom
copilot/add-terminal-gui-interop-spectre-bridge-package

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 24, 2026

  • Review new @copilot PR comment and determine if code changes are required
  • Check recent CI/workflow run status for the branch
  • Verify docfx/API metadata configuration for Terminal.Gui.Interop.Spectre
  • Reply to the PR comment with a precise answer and screenshot link if needed

Copilot AI changed the title [WIP] Add Terminal.Gui.Interop.Spectre bridge package with markup parsing and style conversion Fixes #issue. Add Spectre markup interop bridge package May 24, 2026
Copilot finished work on behalf of tig May 24, 2026 00:35
Copilot AI requested a review from tig May 24, 2026 00:35
@tig
Copy link
Copy Markdown
Member

tig commented May 24, 2026

@copilot add a UICatalog scenario that shows this off.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 24, 2026

@copilot add a UICatalog scenario that shows this off.

Implemented in commit 5fac1c7.

Added a new UICatalog scenario: Spectre Markup Bridge (Examples/UICatalog/Scenarios/SpectreMarkupBridgeScenario.cs) and wired UICatalog.csproj to reference Terminal.Gui.Interop.Spectre.

Screenshot:
Spectre Markup Bridge scenario

Copilot AI changed the title Fixes #issue. Add Spectre markup interop bridge package Fixes #issue. Add Spectre markup interop bridge package and UICatalog scenario May 24, 2026
Copilot finished work on behalf of tig May 24, 2026 01:46
@tig
Copy link
Copy Markdown
Member

tig commented May 24, 2026

@copilot use gui-cs/tuirec to record a gif of the new scenario in action and add the gif to docs/images.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 24, 2026

@copilot use gui-cs/tuirec to record a gif of the new scenario in action and add the gif to docs/images.

Done in commit bdcfb3b.

I recorded the new Spectre Markup Bridge scenario with gui-cs/tuirec and added the GIF to:
docfx/images/spectre-markup-bridge.gif

I also linked it from Examples/UICatalog/README.md.

Spectre Markup Bridge GIF

Copilot AI changed the title Fixes #issue. Add Spectre markup interop bridge package and UICatalog scenario Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, and tuirec GIF docs May 24, 2026
Copilot finished work on behalf of tig May 24, 2026 01:55
@tig
Copy link
Copy Markdown
Member

tig commented May 24, 2026

@copilot that video shows nothing

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 24, 2026

@copilot that video shows nothing

Updated in commit 19f6877.

I re-recorded the scenario GIF with clearer, visible interaction (editing markup and re-applying) and replaced:
docfx/images/spectre-markup-bridge.gif

Updated Spectre Markup Bridge GIF

Copilot AI changed the title Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, and tuirec GIF docs Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, and tuirec GIF docs (updated demo recording) May 24, 2026
Copilot finished work on behalf of tig May 24, 2026 02:11
@tig
Copy link
Copy Markdown
Member

tig commented May 24, 2026

@copilot see the code cleanup .md doc in ./.claude and use it on all touched files.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 24, 2026

@copilot see the code cleanup .md doc in ./.claude and use it on all touched files.

Done in commit b0636e87f.

I applied the .claude/tasks/clean-code-review.md cleanup pass across the touched source files in this PR (including target-typed new () cleanup and handler formatting normalization).

Current scenario screenshot:
Spectre Markup Bridge

Copilot AI changed the title Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, and tuirec GIF docs (updated demo recording) Fixes #issue. Add Spectre markup interop bridge package, UICatalog scenario, tuirec GIF docs, and cleanup pass May 24, 2026
Copilot finished work on behalf of tig May 24, 2026 02:42
@tig
Copy link
Copy Markdown
Member

tig commented May 24, 2026

@copilot will the Api docs for the spectre intern stuff appear in the TG docs?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 24, 2026

@copilot will the Api docs for the spectre intern stuff appear in the TG docs?

Not as-is.

Right now docfx metadata is configured for Terminal.Gui.dll, Terminal.Gui.Editor.dll, and UICatalog project docs, but it does not include Terminal.Gui.Interop.Spectre, so those API types won’t appear in the published TG API docs unless we add that assembly/project to docfx/docfx.json.

Screenshot:

Copilot finished work on behalf of tig May 24, 2026 02:52
@tig
Copy link
Copy Markdown
Member

tig commented May 24, 2026

Superseded by PR #5393 which consolidates #5391 and #5392 into a single interop package.

@tig tig closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Terminal.Gui.Interop.Spectre bridge package with Markup parsing and Style conversion

2 participants