Fixes #5335. Correct TableView benchmark baselines and per-method IterationSetup#5348
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fc50e0519
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tig
force-pushed
the
tig/fix-tableview-benchmark-baseline
branch
from
6fc50e0 to
ca9db8c
Compare
…rationSetup - Update PageDown_OneStep baselines from ~20ms to ~53ms (matching ScrollDown_OneStep, since both call LayoutAndDraw) - Add missing ScrollUp_OneStep and ScrollRight_OneStep baseline entries - Replace single IterationSetup with targeted setups: ScrollUp starts at the first visible row with RowOffset > 0, ScrollRight starts at the last visible column boundary - Widen cell data to 14+ chars so 10 columns overflow the 120-cell viewport, ensuring CursorRight actually triggers horizontal scrolling Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tig
force-pushed
the
tig/fix-tableview-benchmark-baseline
branch
from
ca9db8c to
5ae9005
Compare
This was referenced May 21, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the false performance gate regression reported in #5335 by correcting invalid baseline values and improving benchmark accuracy.
Changes
Tests/Benchmarks/baseline.jsonPageDown_OneStepbaselines from ~20 ms → ~53 ms (matchingScrollDown_OneStep, since both callLayoutAndDraw()and rendering cost dominates)ScrollUp_OneStepandScrollRight_OneStepentries (both ~53 ms)_commentdocumenting the correctionTests/Benchmarks/Scrolling/TableViewScrollBenchmark.cs[IterationSetup]with targeted per-method setups:IterationSetup_ScrollDown(targets ScrollDown, PageDown, ScrollRight): selection at last visible rowIterationSetup_ScrollUp: selection at first visible row withRowOffsetat mid-table so up-arrow triggers actual scrollingRoot Cause
The original PageDown baseline (~20 ms) was captured under conditions that didn't match the actual benchmark behavior. Since all scroll benchmarks execute
_app.LayoutAndDraw()(full redraw), they should have similar baselines. The ~20 ms value caused 3.5× false regression flags on PRs.Verification
dotnet build Tests/Benchmarks -c Releasepasses