Release v2.2.0-rc.4#5340
Conversation
Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/570bd4e3-1efe-4cb5-a20e-f9a8539afe16 Co-authored-by: tig <585482+tig@users.noreply.github.com>
…behavior Agent-Logs-Url: https://github.com/gui-cs/Terminal.Gui/sessions/53c94fb0-98ab-4611-afa4-36c10b1580dd Co-authored-by: tig <585482+tig@users.noreply.github.com>
Fixes #5338. ListView.MoveUp/MoveDown cycles when TabStop == NoStop
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d78f812e80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| else if (TabStop == TabBehavior.NoStop) | ||
| { | ||
| // Wrap to bottom | ||
| newItem = Source.Count - 1; |
There was a problem hiding this comment.
When MoveUp wraps from the first row to the last row (TabStop == TabBehavior.NoStop), the selected item can end up outside the visible viewport if the list is taller than the viewport (for example, 3 items with height 2). In that path, newItem is set to the last index, but the subsequent viewport adjustment uses SelectedItem > Viewport.Y + Viewport.Height, which does not scroll when the selection lands exactly one row past the visible range, so the newly selected item remains hidden.
Useful? React with 👍 / 👎.
Release v2.2.0-rc.4
This is a rc pre-release.
Version:
2.2.0-rc.4NuGet Package:
Terminal.Gui 2.2.0-rc.4What happens when this PR is merged
v2.2.0-rc.4main→developwill be openedChecklist
2.2.0-rc.4