Skip to content

Fixes #5316. Fix FileDialog End key in path field#5317

Merged
YourRobotOverlord merged 1 commit into
gui-cs:developfrom
YourRobotOverlord:fix/filedialog-end-key-pathfield
May 17, 2026
Merged

Fixes #5316. Fix FileDialog End key in path field#5317
YourRobotOverlord merged 1 commit into
gui-cs:developfrom
YourRobotOverlord:fix/filedialog-end-key-pathfield

Conversation

@YourRobotOverlord
Copy link
Copy Markdown
Collaborator

Copilot Session

[98754f4a-2722-4beb-919b-4ec49c52170e]

Summary

  • Fix FileDialog path-field key filtering so navigation keys like End are not treated as bad characters.
  • Keep bad-character suppression for typed path characters (", <, >, |, *, ?).
  • Add regression tests for both behaviors.

Changes

  • FileDialog.Navigation.SuppressIfBadChar now evaluates only single printable grapheme input.
  • Added FileDialog_PathField_End_MovesInsertionPointToEnd.
  • Added FileDialog_PathField_BadChars_AreSuppressed.
  • Added AppendAutocomplete tests to ensure End is not consumed by autocomplete.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@YourRobotOverlord YourRobotOverlord requested a review from tig as a code owner May 17, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants