Skip to content

Reverts #5133. Revert TableView Home/End FullRowSelect change #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 2 commits into from
May 1, 2026
Merged

Reverts #5133. Revert TableView Home/End FullRowSelect change #5136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3c069
Revert "Fixes #5132. TableView Home/End navigation with FullRowSelect…
tig May 1, 2026
2232917
Docs: Document Home/End rebinding for FullRowSelect in TableView
tig May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions Terminal.Gui/Views/TableView/TableView.Selection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ public bool MoveCursorToEndOfRow (bool extend, ICommandContext? ctx)
return false;
}

if (FullRowSelect)
{
return MoveCursorToEndOfTable (extend, ctx);
}

SetSelection (Table!.Columns - 1, _cursorRow, extend, ctx);
Update ();

Expand All @@ -53,11 +48,6 @@ public bool MoveCursorToStartOfRow (bool extend, ICommandContext? ctx)
return false;
}

if (FullRowSelect)
{
return MoveCursorToStartOfTable (extend, ctx);
}

SetSelection (0, _cursorRow, extend, ctx);
Update ();

Expand Down
26 changes: 0 additions & 26 deletions Tests/UnitTestsParallelizable/Views/TableViewBaselineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,19 +191,6 @@ public void Home_Key_MovesToStartOfRow ()
Assert.Equal (0, tv.Value!.Cursor.Y); // row unchanged
}

[Fact]
public void Home_Key_FullRowSelect_MovesToFirstRow ()
{
// Copilot
TableView tv = CreateTableView (5, 10);
tv.FullRowSelect = true;
tv.SetSelection (3, 5, false);

tv.NewKeyDownEvent (Key.Home);
Assert.Equal (3, tv.Value!.Cursor.X);
Assert.Equal (0, tv.Value!.Cursor.Y);
}

[Fact]
public void End_Key_MovesToEndOfRow ()
{
Expand All @@ -215,19 +202,6 @@ public void End_Key_MovesToEndOfRow ()
Assert.Equal (0, tv.Value!.Cursor.Y); // row unchanged
}

[Fact]
public void End_Key_FullRowSelect_MovesToLastRow ()
{
// Copilot
TableView tv = CreateTableView (5, 10);
tv.FullRowSelect = true;
tv.SetSelection (1, 5, false);

tv.NewKeyDownEvent (Key.End);
Assert.Equal (1, tv.Value!.Cursor.X);
Assert.Equal (9, tv.Value!.Cursor.Y);
}

[Fact]
public void MoveCursorToStartOfTable_MovesToOrigin ()
{
Expand Down
16 changes: 15 additions & 1 deletion docfx/docs/tableview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,20 @@ Extended regions (`IsExtended = true`) persist through keyboard navigation. Non-

When `FullRowSelect` is `true`, entire rows are selected instead of individual cells. All cells in the cursor's row are reported as selected by `GetAllSelectedCells ()` and `IsSelected ()`.

> **Tip — Home/End with FullRowSelect:** By default, `Home` and `End` navigate to the
> start/end of the current *row* (i.e. first/last column). To make `Home`/`End` jump to
> the first/last *row* instead (which is often more useful in full-row mode), rebind them
> to `Command.Start` and `Command.End`:
>
> ```csharp
> tableView.KeyBindings.Remove (Key.Home);
> tableView.KeyBindings.Add (Key.Home, Command.Start);
> tableView.KeyBindings.Remove (Key.End);
> tableView.KeyBindings.Add (Key.End, Command.End);
> ```
>
> This is the pattern used by `UICatalogRunnable` for its scenario list.

### Reading the Selection

```csharp
Expand All @@ -148,7 +162,7 @@ bool sel = tv.IsSelected (col, row);
| Arrow keys | Move cursor one cell |
| Shift+Arrow | Extend selection |
| PageUp / PageDown | Move one page |
| Home / End | Move to start/end of row. With `FullRowSelect`, move to first/last row |
| Home / End | Move to start/end of row |
| Ctrl+Home / Ctrl+End | Move to first/last row |
| Shift+Home/End/Ctrl+Home/Ctrl+End | Extend selection to row/table boundary |
| Ctrl+A | Select all |
Expand Down
Loading