Conversation
- Moved AllowedTypeAny and IAllowedType to separate files - Enhanced Notepad open dialog filters and options - Replaced Enumerable.Empty<T>() with [] literals - Changed CancelButton to CancelButtonIndex (int) - Moved FileDialog UI/filter setup to EndInit - Simplified FileDialogState and FileDialogTableSource - Updated OpenDialog/SaveDialog to use CancelButtonIndex - Applied code style and expression-bodied member improvements
Eliminates tracking and usage of _minimumSubViewsSize. Dialog sizing now only considers viewport, title, and button sizes. OnSubViewAdded override and related calculations are removed for simplification.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nal.Gui into fix/5097-FileDialog
Expanded XML docs for Dialog/Dialog<TResult> to clarify layout, sizing, and scrollbar limitations. Added filedialog-state-refactor.md detailing planned FileDialogState refactoring, performance fixes, dead code removal, and new test requirements. Cleaned up redundant remarks in Dialog<TResult> constructor.
Added a protected FileDialogState constructor to support custom child population, updated SearchState to use it, and prevented redundant enumeration. Improved FilepathSuggestionGenerator by fixing nullability, filtering, and type issues for safer and clearer suggestion logic. Also ensured Path is set in all FileDialogState constructors.
Announce v2.0 release, clarify v1 maintenance status, and rewrite README and docs to highlight v2 features, installation, and migration. Remove outdated v1/alpha references and improve navigation and quick start sections.
…nal.Gui into fix/5097-FileDialog
BDisp
approved these changes
Apr 28, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some fixes from code review comments that I forgot to push with #5090 .