Skip to content

Fixes #5065. Pressing Shift-Alt-T in a TextField causes a t to be entered#5063

Merged
BDisp merged 8 commits intogui-cs:developfrom
BDisp:enforce-kitty-test
Apr 25, 2026
Merged

Fixes #5065. Pressing Shift-Alt-T in a TextField causes a t to be entered#5063
BDisp merged 8 commits intogui-cs:developfrom
BDisp:enforce-kitty-test

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Apr 23, 2026

Fixes

Proposed Changes/Todos

  • I would like to add the kitty addition test lines to reinforce the Key values. Thanks

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner April 23, 2026 13:48
@BDisp BDisp changed the title Enforce kitty test for Alt+T Reinforce kitty test for Alt+T Apr 23, 2026
@BDisp BDisp marked this pull request as draft April 23, 2026 14:01
@BDisp BDisp changed the title Reinforce kitty test for Alt+T Fixes #5065. Pressing Shift-Alt-T in a TextField causes a t to be entered Apr 23, 2026
@BDisp BDisp marked this pull request as ready for review April 23, 2026 18:13
@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Apr 23, 2026

I don't think anything else needs to be changed. As far as I'm concerned, it's ready for review. Thanks.

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Apr 24, 2026

@tig I think you've been having some difficulty getting certain key combinations to work correctly when pressing keys, as some implicit combinations weren't being processed and others weren't being preserved when pressing more keys.

@BDisp BDisp marked this pull request as draft April 24, 2026 21:50
@tig tig marked this pull request as ready for review April 24, 2026 21:53
@tig tig marked this pull request as draft April 24, 2026 21:53
@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Apr 24, 2026

Still having a bug. I'll fix it.

Co-authored-by: Copilot <copilot@github.com>
@BDisp BDisp marked this pull request as ready for review April 24, 2026 22:45
@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Apr 24, 2026

I think that all ok now with press and release events.

@BDisp
Copy link
Copy Markdown
Collaborator Author

BDisp commented Apr 24, 2026

@tig you approved before I made a last commit and so I don't know if I can merge this. I'll wait for you say something. Thanks.

Copy link
Copy Markdown
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pressing Shift-Alt-T in a TextField causes a t to be entered

2 participants