Fixes #4879. SpinnerView AutoSpin does not advance animation#4882
Merged
tig merged 3 commits intogui-cs:v2_developfrom Apr 5, 2026
Merged
Fixes #4879. SpinnerView AutoSpin does not advance animation#4882tig merged 3 commits intogui-cs:v2_developfrom
tig merged 3 commits intogui-cs:v2_developfrom
Conversation
AutoSpin = true is typically set before the view is added to an application. App.AddTimeout cannot be called until the view is fully initialized with a running App, which happens during EndInit() inside app.Run(). Add _autoSpin backing field to track the desired state independently of the active timer, and override EndInit() to register the repeating timeout once App is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
YourRobotOverlord
force-pushed
the
fix/4879-spinnerview-autospin
branch
from
e588c24 to
42ca9f4
Compare
tig
requested changes
Apr 4, 2026
Member
tig
left a comment
tig
left a comment
There was a problem hiding this comment.
Thank you for doing this. Please add a test that will ensure this bug can't occur again.
tig
approved these changes
Apr 5, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4879.
AutoSpin = true is typically set before the view is added to an application (e.g. in an object initializer or scenario setup). App.AddTimeout cannot be called until the view is fully initialized with a running App, which only happens during EndInit() inside App.Run().
Root Cause
When AutoSpin = true is set on a SpinnerView before App.Run() is called, App is
null. AddAutoSpinTimeout() silently exits without registering a timer. Nothing ever retried - the spinner showed its first frame and stopped.
Fix