Fixes #4854. Adornment SubView LineCanvas auto-join pipeline fix#4855
Closed
tig wants to merge 2 commits intogui-cs:v2_developfrom
Closed
Fixes #4854. Adornment SubView LineCanvas auto-join pipeline fix#4855tig wants to merge 2 commits intogui-cs:v2_developfrom
tig wants to merge 2 commits intogui-cs:v2_developfrom
Conversation
…-cs#4854) Add AdornmentSubViewLineCanvasTests with two Skip'd tests that demonstrate the bug: DoDrawAdornmentsSubViews runs AFTER DoRenderLineCanvas, so adornment SubView border lines merged via LineCanvas.Merge arrive too late for auto-join with the parent's border. Tests cover Border and Padding SubViews with SuperViewRendersLineCanvas. Both verify that junction glyphs (┴) should appear where SubView borders meet parent borders — currently they don't. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Three changes to enable adornment SubView border lines (via SuperViewRendersLineCanvas) to auto-join with the parent View's border: 1. Reorder draw pipeline: DoDrawAdornmentsSubViews now runs BEFORE DoRenderLineCanvas so merged lines are present when the LineCanvas renders. 2. Skip Exclude for SuperViewRendersLineCanvas SubViews: These SubViews contribute LC lines via Merge that should fill their positions, not be excluded from rendering. 3. Don't clear AdornmentView LineCanvas in ClearNeedsDraw: AdornmentView LC may hold merged SubView lines that haven't been consumed by the parent's DoDrawAdornmentsSubViews yet. Those lines are cleared after merging into the parent's LC. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix will be in :
Adornmentsand RewritesTabView#4829Problem
Adornment SubViews with
SuperViewRendersLineCanvas = truecan't get theirLineCanvaslines auto-joined with the parent View's border. Lines are merged but never rendered.Root Cause (two bugs)
ClearNeedsDraw()clears AdornmentView LC prematurely: AfterborderView.Draw(),ClearNeedsDraw()callsLineCanvas.Clear()— wiping merged SubView lines beforeDoDrawAdornmentsSubViewscan consume them.LineCanvas.Exclude()blocks merged lines: The Exclude for SVRLC SubViews prevents their merged lines from appearing inGetCellMap.Fix
Three changes in
View.Drawing.csandView.NeedsDraw.cs:DoDrawAdornmentsSubViewsbeforeDoRenderLineCanvasso merged lines are present when LC renders.ClearNeedsDraw: Preserve merged lines for the parent's merge.Tests
BorderSubView_Lines_Not_Rendered— minimal repro: 7×3 View, top-only border, SubView adds double-line via SVRLC. Verifies──═══──renders correctly.Verification
All 15,162 tests pass on the tabview branch where the full pipeline is exercised.