Fixes #4848. Set Console.OutputEncoding to UTF-8 in AnsiOutput#4849
Merged
tig merged 7 commits intogui-cs:v2_developfrom Mar 24, 2026
Merged
Fixes #4848. Set Console.OutputEncoding to UTF-8 in AnsiOutput#4849tig merged 7 commits intogui-cs:v2_developfrom
tig merged 7 commits intogui-cs:v2_developfrom
Conversation
The ANSI driver writes UTF-8 encoded bytes via WriteFile but never set the console output code page to 65001 (UTF-8). On a fresh Windows terminal with the default OEM code page (e.g. 437), multi-byte UTF-8 characters (box-drawing glyphs) were misinterpreted as multiple single-byte OEM characters, producing garbled borders and shifted text. Added Console.OutputEncoding = Encoding.UTF8 to the AnsiOutput constructor, matching what NetOutput already does. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ANSI driver writes UTF-8 encoded bytes via \WriteFile\ but never set the console output code page to 65001 (UTF-8). On a fresh Windows terminal with the default OEM code page (e.g. 437), multi-byte UTF-8 characters (box-drawing glyphs like ╔═╗║╚╝) were misinterpreted as multiple single-byte OEM characters, producing garbled borders and shifted text.
Root Cause
\WindowsVTOutputHelper.Write()\ encodes output as UTF-8 via \Encoding.UTF8.GetBytes()\ and writes raw bytes via \WriteFile. The console interprets those bytes according to its output code page. On a fresh terminal this is the system OEM code page (e.g. 437), not UTF-8.
Why it didn't always repro
Fix
Added \Console.OutputEncoding = Encoding.UTF8;\ to the \AnsiOutput\ constructor, matching what \NetOutput\ already does.