Skip to content

Fixes #macOS-tests-failing. Deep-clone hard-coded config cache values at initialization to prevent mutation corruption #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 2 commits into from
Mar 23, 2026
Merged

Fixes #macOS-tests-failing. Deep-clone hard-coded config cache values at initialization to prevent mutation corruption #4847

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26d54a3
Initial plan
Copilot Mar 23, 2026
8393f76
Fix macOS test failures: deep-clone hard-coded config cache values to…
Copilot Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Terminal.Gui/Configuration/ConfigurationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,14 @@ internal static void Initialize ()

foreach (KeyValuePair<string, ConfigProperty> hardCodedProperty in _hardCodedConfigPropertyCache)
{
// Set the PropertyValue to the hard coded value
// Set the PropertyValue to the hard coded value.
// Deep-clone the value to ensure the cache stores independent copies of reference types
// (e.g. Dictionary<,>). Without cloning, in-place mutations to a static property like
// Application.DefaultKeyBindings (e.g. dict[cmd] = ...) would silently corrupt the
// cached "hard-coded default", causing test-order-dependent failures.
hardCodedProperty.Value.Immutable = false;
hardCodedProperty.Value.UpdateToCurrentValue ();
hardCodedProperty.Value.PropertyValue = DeepCloner.DeepClone (hardCodedProperty.Value.PropertyValue);
hardCodedProperty.Value.Immutable = true;
}
}
Expand Down
Loading