Skip to content

Fixes #3985. Cache URI validation in Link to avoid revalidation on every redraw #4833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 2 commits into from
Mar 13, 2026
Merged

Fixes #3985. Cache URI validation in Link to avoid revalidation on every redraw #4833

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76d0da5
Initial plan
Copilot Mar 13, 2026
7fc97ff
perf: cache URI validation in Link to avoid repeated work on redraws
Copilot Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Terminal.Gui/Views/Link.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,16 @@ protected override void UpdateTextFormatterText ()
public const string DEFAULT_URL = "";

private string _url = DEFAULT_URL;
private bool _isUrlValid = false;

/// <summary>
/// Gets or sets the URL (hyperlink target) associated with this <see cref="Link"/>.
/// </summary>
/// <remarks>
/// <para>
/// Any string value is accepted. URL validation occurs at draw time: if the value is not a well-formed
/// absolute URI (per <see cref="Uri.IsWellFormedUriString"/>), the link renders with the
/// <see cref="VisualRole.Disabled"/> style and no OSC 8 hyperlink sequence is emitted.
/// Any string value is accepted. URL validation is performed once when this property is set and the result is
/// cached: if the value is not a well-formed absolute URI (per <see cref="Uri.IsWellFormedUriString"/>), the
/// link renders with the <see cref="VisualRole.Disabled"/> style and no OSC 8 hyperlink sequence is emitted.
/// </para>
/// <para>
/// When <see cref="View.Text"/> is empty, <see cref="Url"/> is used as the display text.
Expand Down Expand Up @@ -319,7 +320,7 @@ protected override bool OnDrawingText (DrawContext? context)
string? url = Url;

// If the URL is not valid, don't set CurrentUrl, and adjust the attributes to indicate it's not well-formed
if (!Uri.IsWellFormedUriString (Url, UriKind.Absolute))
if (!_isUrlValid)
{
normalAttr = GetAttributeForRole (VisualRole.Disabled);
normalAttr = normalAttr with { Background = HasFocus ? GetAttributeForRole (VisualRole.Focus).Background : normalAttr.Background };
Expand Down Expand Up @@ -372,6 +373,7 @@ private void SetUrl (string value)

// Do the work
_url = value;
_isUrlValid = Uri.IsWellFormedUriString (value, UriKind.Absolute);

// CWP: Fire ValueChanged
ValueChangedEventArgs<string> changedArgs = new (oldValue, value);
Expand Down
Loading