Add Unicode grapheme handling guidance#4803
Merged
tig merged 1 commit intogui-cs:v2_developfrom Mar 6, 2026
Merged
Conversation
Add guidance to CONTRIBUTING.md and .claude/rules/ about correct grapheme-aware text handling: use string.GetColumns() for width measurement, iterate by grapheme with GraphemeHelper.GetGraphemes() for rendering, and use AddStr instead of AddRune for grapheme clusters. This documents the patterns that prevent the bugs fixed in gui-cs#4798 and gui-cs#4800 from recurring. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
akrantz
added a commit
to akrantz/Terminal.Gui
that referenced
this pull request
Mar 6, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add guidance to CONTRIBUTING.md and .claude/rules/ about correct grapheme-aware text handling: use string.GetColumns() for width measurement, iterate by grapheme with GraphemeHelper.GetGraphemes() for rendering, and use AddStr instead of AddRune for grapheme clusters.
This documents the patterns that prevent the bugs fixed in #4798 and #4800 from recurring.
Fixes
Proposed Changes/Todos
.claude/rules/unicode-graphemes.mdfor AI agent guidancePull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)