Use grapheme iteration in DrawHotString#4801
Merged
tig merged 3 commits intogui-cs:v2_developfrom Mar 7, 2026
Merged
Conversation
DrawHotString iterated by rune via EnumerateRunes and rendered each rune individually with AddRune. This breaks grapheme clusters: combining marks sent separately via AddRune fail to compose with their base character (e.g. e + combining acute renders as two separate characters instead of 'é'). Replace with GraphemeHelper.GetGraphemes iteration and AddStr, which preserves grapheme cluster integrity. The hotkey specifier check is unchanged — it only matches single-character graphemes. Added tests: - DrawHotString_CombiningMarks: 3 cases verifying combining marks compose correctly (acute accent, tilde, embedded in word) - DrawHotString_HotkeyWithCombiningMarks: hotkey + combining marks Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Move DrawHotString grapheme tests from UnitTests to UnitTestsParallelizable per review feedback. Adapt tests to use CreateTestDriver() pattern instead of [SetupFakeApplication]. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
akrantz
added a commit
to akrantz/Terminal.Gui
that referenced
this pull request
Mar 6, 2026
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DrawHotString iterated by rune via EnumerateRunes and rendered each rune individually with AddRune. This breaks grapheme clusters: combining marks sent separately via AddRune fail to compose with their base character (e.g. e + combining acute renders as two separate characters instead of 'é').
Replace with GraphemeHelper.GetGraphemes iteration and AddStr, which preserves grapheme cluster integrity. The hotkey specifier check is unchanged — it only matches single-character graphemes.
Added tests:
Fixes
Proposed Changes/Todos
EnumerateRunes()withGraphemeHelper.GetGraphemes()inDrawHotStringAddRune(rune)withAddStr(grapheme)to preserve grapheme cluster integrityPull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)