Use string.GetColumns() for display width#4799
Merged
tig merged 3 commits intogui-cs:v2_developfrom Mar 7, 2026
Merged
Conversation
Replace EnumerateRunes().Sum(GetColumns) with string.GetColumns() for grapheme-aware width measurement. The rune-sum pattern produces incorrect (inflated) results for multi-rune grapheme clusters like ZWJ emoji sequences -- e.g. a family emoji measures 8 columns by rune sum but occupies only 2 terminal cells. Also fix Branch.GetWidth() which used string.Length instead of GetColumns(), under-counting width for wide CJK characters. Fixed instances: - AppendAutocomplete.cs: autocomplete fragment width - ColorBar.cs: color label offset (removed obsolete TODO comment) - FileDialog.cs: feedback text centering - TabView.cs: tab header width - TableView.cs (4 instances): column auto-sizing, truncation, padding - Branch.cs: line truncation check + GetWidth() calculation Added tests: - StringTests: 7 parameterized cases documenting rune-sum vs GetColumns discrepancy for ZWJ emoji, CJK, combining marks, and ASCII - TableViewTests: grapheme cluster width comparison + rendering test - TabViewTests: rendering test verifying emoji tab header width - TreeViewTests: rendering test with CJK wide characters Fixes gui-cs#4798 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tig
requested changes
Mar 6, 2026
Collaborator
tig
left a comment
tig
left a comment
There was a problem hiding this comment.
See my comments. Thank you for taking this on!!!
Move grapheme width tests from UnitTests to UnitTestsParallelizable per review feedback. Adapt tests to use CreateTestDriver() pattern instead of [SetupFakeApplication]. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
akrantz
added a commit
to akrantz/Terminal.Gui
that referenced
this pull request
Mar 6, 2026
tig
approved these changes
Mar 7, 2026
Collaborator
tig
left a comment
tig
left a comment
There was a problem hiding this comment.
Nicely done. Very much appreciated.
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace EnumerateRunes().Sum(GetColumns) with string.GetColumns() for grapheme-aware width measurement. The rune-sum pattern produces incorrect (inflated) results for multi-rune grapheme clusters like ZWJ emoji sequences -- e.g. a family emoji measures 8 columns by rune sum but occupies only 2 terminal cells.
Also fix Branch.GetWidth() which used string.Length instead of GetColumns(), under-counting width for wide CJK characters.
Fixed instances:
Added tests:
Fixes
Proposed Changes/Todos
EnumerateRunes().Sum(GetColumns)withstring.GetColumns()in 6 widget files (10 instances)Branch.GetWidth()usingstring.Lengthinstead ofGetColumns()Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)