Fix MessageBox not setting SchemeName correctly (#4567)#4568
Merged
tig merged 4 commits intogui-cs:v2_developfrom Jan 13, 2026
Merged
Fix MessageBox not setting SchemeName correctly (#4567)#4568tig merged 4 commits intogui-cs:v2_developfrom
tig merged 4 commits intogui-cs:v2_developfrom
Conversation
Uncommented line in MessageBox.cs that sets the SchemeName property based on whether it's an error dialog or regular dialog. Added unit tests to verify Query sets "Dialog" scheme and ErrorQuery sets "Error" scheme. Fixes gui-cs#4567 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2_develop #4568 +/- ##
==============================================
+ Coverage 77.62% 77.65% +0.02%
==============================================
Files 427 427
Lines 45364 45362 -2
Branches 6400 6400
==============================================
+ Hits 35216 35226 +10
+ Misses 8319 8306 -13
- Partials 1829 1830 +1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Query_Sets_Dialog_SchemeName: Verifies MessageBox.Query uses the Dialog color schemeErrorQuery_Sets_Error_SchemeName: Verifies MessageBox.ErrorQuery uses the Error color schemeTest plan
Related
Fixes #4567
🤖 Generated with Claude Code