-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2944. Makes ColorScheme
explicitly readonly, removes Colors.Base
, etc..., Fixes intermittent TreeView
unit test failures
#3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tig
changed the title
Fixes #2944. intermittent
Fixes #2944. Makes Jan 15, 2024
TreeView
unit test failuresColorScheme
explicitly readonly, removes Colors.Base
, etc..., Fixes intermittent TreeView
unit test failures
BDisp
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Third (or fourth?) try is a charm???
TreeView
sometimes causing unit test failure #2944Proposed Changes/Todos
ColorScheme
as it seems the likely culprit.ColorScheme
andColor
toColorSchemes.cs
PlatformColor
to-1
inMake
Color
andColorScheme
more robust byColorScheme
effectively immutable. Changing it toreadonly struct
(value type) will require too many code changes at this point... I'd rather wait for Colors:ColorSchemes
refactor - Should honor terminal color settings etc... #2381 to do that.Colors.Base
, etc... All code now usesColors.ColorSchemes["Base"]
style.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)