Fixes #2305. Improves the handling of escape sequence. by BDisp · Pull Request #2375 · gui-cs/Terminal.Gui

BDisp · 2023-02-22T00:57:22Z

Fixes #2305 - Added the EscSeqUtils which will handle escape sequences from the NetDriver and the CursesDriver. The mouse management on CursesDriver is now managed with the EscSeqUtils class.

Fixes #1617

Pull Request checklist:

I've named my PR in the form of "Fixes #issue. Terse description."
My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
My code follows the Terminal.Gui library design guidelines
I ran dotnet test before commit
I have made corresponding changes to the API documentation (using /// style comments)
My changes generate no new warnings
I have checked my code and corrected any poor grammar or misspellings
I conducted basic QA to assure all features are working

…f border is null.

…exit-fix Improves HeightAsBuffer although currently only works on Windows.

… drawing after exceptions.

…rminal.gui into fixes_2261_scroll_buffer_cleared_on_exit

tig

I didn't have time to finish but this is REALLY AWESOME.

You've removed a huge amount of code in doing this which fantastic.

One of us will need to merge in the work I did in #2261 though. Ugh.

I'll add more comments when I have time.

Please don't take my comments on terminology and wording personally. I know English is not your first language and that's just a fact. My goal here is to help!

BDisp · 2023-02-22T12:04:22Z

I didn't have time to finish but this is REALLY AWESOME.

You've removed a huge amount of code in doing this which fantastic.

Thanks.

One of us will need to merge in the work I did in #2261 though. Ugh.

I'll merge #2261 into this PR and you comment what is wrong when reviewing.

I'll add more comments when I have time.

Please don't take my comments on terminology and wording personally. I know English is not your first language and that's just a fact. My goal here is to help!

No worry @tig. You know that the documentation it isn't my favorite part and I only really appreciate all the helps on this matter. Thank you so much.

BDisp · 2023-02-24T02:58:15Z

All done @tig.

BDisp · 2023-02-24T15:58:52Z

I don't understand why I only see 1177 tests and in the log after run is finished I see 1178 and none skipped. This is also happens with the developer branch. Is this a xunit bug?

[xUnit.net 00:00:00.64]   Discovered:  UnitTests
========== Test discovery finished: 1177 Tests found in 1,1 sec ==========
========== Starting test run ==========
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.5+1caef2f33e (64-bit .NET 7.0.3)
[xUnit.net 00:00:00.64]   Starting:    UnitTests
[xUnit.net 00:00:56.63]   Finished:    UnitTests
========== Test run finished: 1178 Tests (1178 Passed, 0 Failed, 0 Skipped) run in 56,6 sec ==========

tig · 2023-02-24T21:50:31Z

I'll merge #2261 into this PR and you comment what is wrong when reviewing.

I have not had time to look closely. Did you already do this? If so, I'll close #2261.

BDisp · 2023-02-24T21:55:00Z

I have not had time to look closely. Did you already do this? If so, I'll close #2261.

I think I did it properly and if more some fix is needed we do later. I think you can close.

@BDisp

…2375) * Changed ansi esc sequence used on exit. * Changed ansi esc sequence used on exit. * Improves HeightAsBuffer although currently only works on Windows. * Fixes gui-cs#2267. Toplevel.EnsureVisibleBounds throws an exception if border is null. * Changing comment as requested. * Fixes indentation. * Seems not needed for now, maybe some update, comment for now. * Renamed HeightAsBuffer to EnableConsoleScrolling and made it obsolete. * Add comment on remarks for EnableConsoleScrolling. * merged @BDisp's EnableConsoleScrolling PR * Fixes buffer for Windows Terminal. * Fixes issue in Windows Terminal on resizing causing some lines not be drawing after exceptions. * merge #9 * merged #9 * use ESC [ ? 1047 * Tweaks with new esc codes * Fixed curses driver to not nuke scroll buffer and to resize properly * merge * Cleand up netdriver escape codes * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed merge issue and spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed spaces->tabs * fixed build error * removed old comments * Resolving merge conflicts. * Ensuring reset the EnableConsoleScrolling. * Changing from HeightAsBuffer to EnableConsoleScrolling. * Done requested changes. * Reformatting. * Rename to EscSeqReqStatus. * Removing Console.Out.Flush (); --------- Co-authored-by: Charlie Kindel <tig@users.noreply.github.com> Co-authored-by: Tig Kindel <tig@kindel.com>

tig and others added 30 commits January 1, 2023 10:48

Changed ansi esc sequence used on exit.

2c3c396

Changed ansi esc sequence used on exit.

7dec9f7

Merge branch 'develop' into fixes_2261_scroll_buffer_cleared_on_exit

1560267

Improves HeightAsBuffer although currently only works on Windows.

c5ebfcf

Fixes gui-cs#2267. Toplevel.EnsureVisibleBounds throws an exception i…

1aab780

…f border is null.

Changing comment as requested.

c23cbd5

Fixes indentation.

de45dd9

Seems not needed for now, maybe some update, comment for now.

4832e73

Renamed HeightAsBuffer to EnableConsoleScrolling and made it obsolete.

2e55705

Add comment on remarks for EnableConsoleScrolling.

7c832e8

Merge pull request #8 from BDisp/fixes_2261_scroll_buffer_cleared_on_…

47b3acf

…exit-fix Improves HeightAsBuffer although currently only works on Windows.

merged @BDisp's EnableConsoleScrolling PR

ad13b85

Fixes buffer for Windows Terminal.

acb6060

Fixes issue in Windows Terminal on resizing causing some lines not be…

d56b4dc

… drawing after exceptions.

merge #9

2e8dbf9

merged #9

12e664e

use ESC [ ? 1047

912b0e7

Tweaks with new esc codes

f3d1284

Fixed curses driver to not nuke scroll buffer and to resize properly

697e068

merge

e85fd20

Cleand up netdriver escape codes

202f0f0

Merge branch 'fixes_2261_scroll_buffer_cleared_on_exit' of tig:tig/Te…

76d51a0

…rminal.gui into fixes_2261_scroll_buffer_cleared_on_exit

fixed spaces->tabs

c462c3b

fixed spaces->tabs

7298eee

fixed spaces->tabs

9576a91

fixed spaces->tabs

f90a482

fixed merge issue and spaces->tabs

636904f

fixed spaces->tabs

0695904

fixed spaces->tabs

ce37be8

fixed spaces->tabs

60524c7

tig reviewed Feb 22, 2023

View reviewed changes

Comment thread Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs

tig reviewed Feb 22, 2023

View reviewed changes

Comment thread Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs Outdated

tig reviewed Feb 22, 2023

View reviewed changes

Comment thread Terminal.Gui/ConsoleDrivers/CursesDriver/CursesDriver.cs Outdated

tig requested changes Feb 22, 2023

View reviewed changes

Resolving merge conflicts.

436715f

BDisp force-pushed the escape-sequence-utils_2305 branch from e174db6 to 436715f Compare February 24, 2023 02:14

BDisp added 2 commits February 24, 2023 02:42

Resolving merge conflicts.

8369418

Ensuring reset the EnableConsoleScrolling.

d53fe68

BDisp added 3 commits February 24, 2023 03:25

Changing from HeightAsBuffer to EnableConsoleScrolling.

a1b42f7

Done requested changes.

66d0753

Reformatting.

9a73e70

BDisp and others added 3 commits February 24, 2023 23:38

Rename to EscSeqReqStatus.

09e69d5

Removing Console.Out.Flush ();

5c63d1d

Merge branch 'develop' into escape-sequence-utils_2305

e540028

tig approved these changes Feb 25, 2023

View reviewed changes

tig merged commit 1d2dc40 into gui-cs:develop Feb 25, 2023

BDisp deleted the escape-sequence-utils_2305 branch February 25, 2023 22:50

kacperpikacz mentioned this pull request Sep 22, 2023

Application views do not refresh when the cursor is moved. #2860

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #2305. Improves the handling of escape sequence.#2375

Fixes #2305. Improves the handling of escape sequence.#2375
tig merged 43 commits intogui-cs:developfrom
BDisp:escape-sequence-utils_2305

BDisp commented Feb 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tig left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BDisp commented Feb 22, 2023

Uh oh!

BDisp commented Feb 24, 2023

Uh oh!

BDisp commented Feb 24, 2023

Uh oh!

tig commented Feb 24, 2023

Uh oh!

BDisp commented Feb 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

BDisp commented Feb 22, 2023

Pull Request checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tig left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BDisp commented Feb 22, 2023

Uh oh!

BDisp commented Feb 24, 2023

Uh oh!

BDisp commented Feb 24, 2023

Uh oh!

tig commented Feb 24, 2023

Uh oh!

BDisp commented Feb 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants