Fixes 2342. Border: can't change border color in window by Border.BorderBrush.#2345
Merged
tig merged 4 commits intogui-cs:developfrom Feb 25, 2023
Merged
Conversation
Collaborator
Author
|
@tig I know you refactored very well the |
Closed
8 tasks
tig
approved these changes
Feb 24, 2023
Collaborator
|
@BDisp can you please figure out the unit test failures? |
Collaborator
Author
tig
added a commit
to tig/Terminal.Gui
that referenced
this pull request
Feb 26, 2023
BDisp
pushed a commit
to BDisp/Terminal.Gui
that referenced
this pull request
Feb 27, 2023
BDisp
added a commit
to BDisp/Terminal.Gui
that referenced
this pull request
Mar 1, 2023
…derBrush. (gui-cs#2345) * Fixes 2342. Border: can't change border color in window by Border.BorderBrush. * Fixes border initialization. --------- Co-authored-by: Tig <tig@users.noreply.github.com>
tznind
pushed a commit
to tznind/gui.cs
that referenced
this pull request
May 7, 2023
…derBrush. (gui-cs#2345) * Fixes 2342. Border: can't change border color in window by Border.BorderBrush. * Fixes border initialization. --------- Co-authored-by: Tig <tig@users.noreply.github.com>
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2342 - Include a feature to set the margin frame and title colors base on the setting of the
Border.BorderBrushand theBorder.Backgroundproperties. Also added xml documents to the true color.Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)