Skip to content

Fixes #2331. ScrollView may not be honoring clip region; CustomButton shows outside#2338

Merged
tig merged 2 commits intogui-cs:developfrom
BDisp:scrollview-clip-fix_2331
Feb 10, 2023
Merged

Fixes #2331. ScrollView may not be honoring clip region; CustomButton shows outside#2338
tig merged 2 commits intogui-cs:developfrom
BDisp:scrollview-clip-fix_2331

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Feb 9, 2023

Fixes #2331 - The ScrollView clip region wasn't been taken with the position offset.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, you're great and digging into these issues and fixing them quicly! Nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ScrollView may not be honoring clip region; CustomButton shows outside

2 participants