Skip to content

Fixes #2328. TextView Autocomplete triggered by cursor move.#2330

Merged
tig merged 1 commit intogui-cs:developfrom
BDisp:autocomplete-move-fix_2328
Feb 8, 2023
Merged

Fixes #2328. TextView Autocomplete triggered by cursor move.#2330
tig merged 1 commit intogui-cs:developfrom
BDisp:autocomplete-move-fix_2328

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Feb 8, 2023

Fixes #2328 - With this PR the Autocomplete popup will only show by typing a key or the Reopen key. However it's also possible show by set the TextView.CursorPosition. But the issue is only related with cursor move and mouse button click.
@tznind please review because I don't want to broken anything. Thanks.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TextView Autocomplete triggered by cursor move

2 participants