Skip to content

Fixes #2317. Drivers do not normalize accented letters.#2318

Merged
tig merged 2 commits intogui-cs:developfrom
BDisp:normalize-drivers-fix_2317
Feb 5, 2023
Merged

Fixes #2317. Drivers do not normalize accented letters.#2318
tig merged 2 commits intogui-cs:developfrom
BDisp:normalize-drivers-fix_2317

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Feb 5, 2023

Fixes #2317 - The accented letters must be normalized before added to the contents and the current column mustn't advance. I hope this fix doesn't broke anything.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing we should really fix in v2 is refactoring ConsoleDriver to reduce the amount of duplicate code/logic found in all the drivers. See #2319

Nice job on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drivers do not normalize accented letters.

2 participants