Skip to content

Fixes #2308. Redraw passed bounds bigger than its client area.#2309

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:redraw-bounds-needdisplay-fix_2308
Feb 5, 2023
Merged

Fixes #2308. Redraw passed bounds bigger than its client area.#2309
tig merged 3 commits intogui-cs:developfrom
BDisp:redraw-bounds-needdisplay-fix_2308

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jan 29, 2023

Fixes #2308 - The Bounds client are is now passing correctly to the Redraw method. The NeedDisplay now have all the old and new area where can be used to clear all the changed area. Normally a container clear all the client area before redraw the sub-views, but there are cases where this is necessary.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp marked this pull request as draft January 30, 2023 12:37
@BDisp BDisp marked this pull request as ready for review January 30, 2023 13:14
Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redraw passed bounds bigger than its client area

2 participants