Skip to content

Fixes #2293. WindowsDriver forces minimum console height equal to 1, but should allow be 0.#2294

Merged
tig merged 2 commits intogui-cs:developfrom
BDisp:windowsdriver-height-fix_2293
Jan 18, 2023
Merged

Fixes #2293. WindowsDriver forces minimum console height equal to 1, but should allow be 0.#2294
tig merged 2 commits intogui-cs:developfrom
BDisp:windowsdriver-height-fix_2293

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Jan 17, 2023

Fixes #2293 - Only the 'OutputHandle' can be set a height to 0 and the ScreenBuffer must have a minimum height of 1, in the case where we don't want use buffer.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

windows-driver-height-0-fix

Copy link
Copy Markdown
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch & fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WindowsDriver forces minimum console height equal to 1, but should allow be 0.

2 participants