Skip to content

Fixes #2277. Changing TextField.Text does not clear text selection. #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 1 commit into from
Jan 5, 2023
Merged

Fixes #2277. Changing TextField.Text does not clear text selection. #2278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Terminal.Gui/Views/TextField.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,7 @@ public override Rect Frame {
}
return;
}
ClearAllSelection ();
text = TextModel.ToRunes (newText.NewText);

if (!Secret && !historyText.IsFromHistory) {
Expand Down
27 changes: 27 additions & 0 deletions UnitTests/TextFieldTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1296,5 +1296,32 @@ public void HistoryText_IsDirty_ClearHistoryChanges ()
Assert.Equal ($"{text}A", tf.Text);
Assert.True (tf.IsDirty);
}

[InlineData ("a")] // Lower than selection
[InlineData ("aaaaaaaaaaa")] // Greater than selection
[InlineData ("aaaa")] // Equal than selection
[Theory]
public void TestSetTextAndMoveCursorToEnd_WhenExistingSelection (string newText)
{
var tf = new TextField ();
tf.Text = "fish";
tf.CursorPosition = tf.Text.Length;

tf.ProcessKey (new KeyEvent (Key.CursorLeft, new KeyModifiers ()));

tf.ProcessKey (new KeyEvent (Key.CursorLeft | Key.ShiftMask, new KeyModifiers { Shift = true }));
tf.ProcessKey (new KeyEvent (Key.CursorLeft | Key.ShiftMask, new KeyModifiers { Shift = true }));

Assert.Equal (1, tf.CursorPosition);
Assert.Equal (2, tf.SelectedLength);
Assert.Equal ("is", tf.SelectedText);

tf.Text = newText;
tf.CursorPosition = tf.Text.Length;

Assert.Equal (newText.Length, tf.CursorPosition);
Assert.Equal (0, tf.SelectedLength);
Assert.Null (tf.SelectedText);
}
}
}