Fixes #2269. ListView.EnsureSelectedItemVisible must be public.

[BDisp]

Fixes #2269 - Also added unit tests and fix StartsWith warning.

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tznind]

Is it worth naming this 'EnsureSelectedItemVisible' to be consistent with other views? TreeView has EnsureVisible TableView has EnsureSelectedCellIsVisible

…

On Tue, 3 Jan 2023, 14:02 BDisp, ***@***.***> wrote: Fixes #2269 <#2269> - Also added unit tests and fix StartsWith warning. Pull Request checklist: - I've named my PR in the form of "Fixes #issue. Terse description." - My code follows the style guidelines of Terminal.Gui <https://github.com/gui-cs/Terminal.Gui/blob/develop/.editorconfig> - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing. - My code follows the Terminal.Gui library design guidelines <https://github.com/gui-cs/Terminal.Gui/blob/develop/CONTRIBUTING.md> - I ran dotnet test before commit - I have made corresponding changes to the API documentation (using /// style comments) - My changes generate no new warnings - I have checked my code and corrected any poor grammar or misspellings - I conducted basic QA to assure all features are working ------------------------------ You can view, comment on, or merge this pull request online at: #2270 Commit Summary - b44df1c <b44df1c> Fixes #2269. ListView.EnsuresVisibilitySelectedItem must be public. File Changes (2 files <https://github.com/gui-cs/Terminal.Gui/pull/2270/files>) - *M* Terminal.Gui/Views/ListView.cs <https://github.com/gui-cs/Terminal.Gui/pull/2270/files#diff-f7e7cfdef83e80b88b150ed4239c1d684ae109ea833b995091d1bd85bc5dd810> (9) - *M* UnitTests/ListViewTests.cs <https://github.com/gui-cs/Terminal.Gui/pull/2270/files#diff-574af2cc959f3f31d4f795b6618261d433d0c47634ce978537b1db365616d207> (62) Patch Links: - https://github.com/gui-cs/Terminal.Gui/pull/2270.patch - https://github.com/gui-cs/Terminal.Gui/pull/2270.diff — Reply to this email directly, view it on GitHub <#2270>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHO3C5CEPAPLGTG4ZUKTL7LWQQWP7ANCNFSM6AAAAAATPXBNHE> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[BDisp]

Is it worth naming this 'EnsureSelectedItemVisible' to be consistent with other views? TreeView has EnsureVisible TableView has EnsureSelectedCellIsVisible

Done. Thanks @tznind.