Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Terminal.Gui/Views/TableView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -794,22 +794,28 @@ public void PageDown(bool extend)
}

/// <summary>
/// Moves or extends the selection to the first cell in the table (0,0)
/// Moves or extends the selection to the first cell in the table (0,0).
/// If <see cref="FullRowSelect"/> is enabled then selection instead moves
/// to (<see cref="SelectedColumn"/>,0) i.e. no horizontal scrolling.
/// </summary>
/// <param name="extend">true to extend the current selection (if any) instead of replacing</param>
public void ChangeSelectionToStartOfTable (bool extend)
{
SetSelection (0, 0, extend);
SetSelection (FullRowSelect ? SelectedColumn : 0, 0, extend);
Update ();
}

/// <summary>
/// Moves or extends the selection to the final cell in the table
/// Moves or extends the selection to the final cell in the table (nX,nY).
/// If <see cref="FullRowSelect"/> is enabled then selection instead moves
/// to (<see cref="SelectedColumn"/>,nY) i.e. no horizontal scrolling.
/// </summary>
/// <param name="extend">true to extend the current selection (if any) instead of replacing</param>
public void ChangeSelectionToEndOfTable(bool extend)
{
SetSelection (Table.Columns.Count - 1, Table.Rows.Count - 1, extend);
var finalColumn = Table.Columns.Count - 1;

SetSelection (FullRowSelect ? SelectedColumn : finalColumn, Table.Rows.Count - 1, extend);
Update ();
}

Expand Down
48 changes: 48 additions & 0 deletions UnitTests/TableViewTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1312,6 +1312,54 @@ public void TestColumnStyle_FirstColumnVisibleFalse_CursorStaysAt1(bool useHome)
Assert.Equal (1, tableView.SelectedColumn);
}


[InlineData(true)]
[InlineData (false)]
[Theory, AutoInitShutdown]
public void TestMoveStartEnd_WithFullRowSelect(bool withFullRowSelect)
{
var tableView = GetTwoRowSixColumnTable ();
tableView.FullRowSelect = withFullRowSelect;

tableView.SelectedRow = 1;
tableView.SelectedColumn = 1;

tableView.ProcessKey (new KeyEvent
{
Key = Key.Home | Key.CtrlMask
});

if(withFullRowSelect)
{
// Should not be any horizontal movement when
// using navigate to Start/End and FullRowSelect
Assert.Equal (1, tableView.SelectedColumn);
Assert.Equal (0, tableView.SelectedRow);
}
else
{
Assert.Equal (0, tableView.SelectedColumn);
Assert.Equal (0, tableView.SelectedRow);
}

tableView.ProcessKey (new KeyEvent
{
Key = Key.End | Key.CtrlMask
});

if(withFullRowSelect)
{
Assert.Equal (1, tableView.SelectedColumn);
Assert.Equal (1, tableView.SelectedRow);
}
else
{
Assert.Equal (5, tableView.SelectedColumn);
Assert.Equal (1, tableView.SelectedRow);
}

}

[InlineData (true)]
[InlineData (false)]
[Theory, AutoInitShutdown]
Expand Down