Skip to content

Fixes #2163 and #2140 - ListView: OnSelectedChanged is called when it didn't actually change (again) #2164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tig merged 1 commit into from
Nov 3, 2022
Merged

Fixes #2163 and #2140 - ListView: OnSelectedChanged is called when it didn't actually change (again) #2164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Terminal.Gui/Views/ListView.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,6 @@ public override bool OnEnter (View view)

if (lastSelectedItem == -1) {
EnsuresVisibilitySelectedItem ();
OnSelectedChanged ();
}

return base.OnEnter (view);
Expand Down
36 changes: 18 additions & 18 deletions UnitTests/ComboBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,9 +826,9 @@ cb.Subviews [1].GetNormalColor ()

TestHelpers.AssertDriverColorsAre (@"
000000
00000
22222
22222", attributes);
222222
222222
222222", attributes);

Assert.True (cb.Subviews [1].ProcessKey (new KeyEvent (Key.CursorDown, new KeyModifiers ())));
Assert.Equal ("", selected);
Expand All @@ -838,9 +838,9 @@ cb.Subviews [1].GetNormalColor ()
cb.Redraw (cb.Bounds);
TestHelpers.AssertDriverColorsAre (@"
000000
22222
00000
22222", attributes);
222222
000002
222222", attributes);

Assert.True (cb.Subviews [1].ProcessKey (new KeyEvent (Key.CursorDown, new KeyModifiers ())));
Assert.Equal ("", selected);
Expand All @@ -850,9 +850,9 @@ cb.Subviews [1].GetNormalColor ()
cb.Redraw (cb.Bounds);
TestHelpers.AssertDriverColorsAre (@"
000000
22222
22222
00000", attributes);
222222
222222
000002", attributes);

Assert.True (cb.Subviews [1].ProcessKey (new KeyEvent (Key.Enter, new KeyModifiers ())));
Assert.Equal ("Three", selected);
Expand All @@ -868,9 +868,9 @@ cb.Subviews [1].GetNormalColor ()
cb.Redraw (cb.Bounds);
TestHelpers.AssertDriverColorsAre (@"
000000
22222
22222
00000", attributes);
222222
222222
000002", attributes);

Assert.True (cb.Subviews [1].ProcessKey (new KeyEvent (Key.CursorUp, new KeyModifiers ())));
Assert.Equal ("Three", selected);
Expand All @@ -880,9 +880,9 @@ cb.Subviews [1].GetNormalColor ()
cb.Redraw (cb.Bounds);
TestHelpers.AssertDriverColorsAre (@"
000000
22222
00000
11111", attributes);
222222
000002
111112", attributes);

Assert.True (cb.Subviews [1].ProcessKey (new KeyEvent (Key.CursorUp, new KeyModifiers ())));
Assert.Equal ("Three", selected);
Expand All @@ -892,9 +892,9 @@ cb.Subviews [1].GetNormalColor ()
cb.Redraw (cb.Bounds);
TestHelpers.AssertDriverColorsAre (@"
000000
00000
22222
11111", attributes);
000002
222222
111112", attributes);

Assert.True (cb.ProcessKey (new KeyEvent (Key.F4, new KeyModifiers ())));
Assert.Equal ("Three", selected);
Expand Down