TreeView: Now highlights only model text#2155
Merged
tig merged 3 commits intogui-cs:developfrom Nov 2, 2022
Merged
Conversation
Member
Author
|
@tznind please review! |
Collaborator
|
Looks great, thanks for this and for making it toggleable <3. Only issue I can see is that the highlight color does not match ListView... seems to be Blue on White instead of Black on White. Seems to be a regression vs main gui.cs branch.
|
Collaborator
|
Also I think we should add the Style setting in here too TreeViewFileSystem. That Scenario has all the toggle able options so should have the new one too. There is a bit of redundancy in Class Explorer and TreeViewFileSystem. I think later on we could look to share more code between them or scrap one/merge.
|
This was referenced Nov 2, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
StylenamedHighlightModelTextOnly- false by defaultClass ExplorerScenario to have a menu for testing new StyleSee: #2154