Fixes 2142. Dim.Combine wasn't calculating well.

[BDisp]

Fixes #2142- Dim.Combine wasn't calculating considering each Dim type and wasn't recursive running.

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tznind]

Nice thanks for this fix. Does the issue exist in PosCombine too? or was it just Dim that had the issue? Worth replicating the test for Pos even if it is a solved problem.

[BDisp]

Nice thanks for this fix. Does the issue exist in PosCombine too? or was it just Dim that had the issue? Worth replicating the test for Pos even if it is a solved problem.

Thanks for the remember. I'll check that too.

[BDisp]

Nice thanks for this fix. Does the issue exist in PosCombine too? or was it just Dim that had the issue? Worth replicating the test for Pos even if it is a solved problem.

@tznind do you have any unit test that will fail with the Pos.Combine?

[BDisp]

It seems that there isn't issue with the Pos.Combine.