Skip to content

Fixes #2135. Character Map scenario doesn't show the content view.#2136

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:scrollview-content-view-fix
Oct 29, 2022
Merged

Fixes #2135. Character Map scenario doesn't show the content view.#2136
tig merged 3 commits intogui-cs:developfrom
BDisp:scrollview-content-view-fix

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Oct 25, 2022

Fixes #2135 - Only to remember that if a container view isn't to intended to be cleared on the Redraw method of the View class, then create a nested private class inherit from the View class.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Character Map scenario doesn't show the content view.

2 participants