Skip to content

Improves the TabView minimum size and added more unit tests.#2105

Merged
tig merged 1 commit intogui-cs:developfrom
BDisp:tabview-minimum-size-improvement
Oct 19, 2022
Merged

Improves the TabView minimum size and added more unit tests.#2105
tig merged 1 commit intogui-cs:developfrom
BDisp:tabview-minimum-size-improvement

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Oct 19, 2022

Improves the TabView minimum size by allowing draw the limits without the text. Also added much more unit tests with different styles.

┌┐ 
││ 
│└►
│h│
└─┘

┌─┐
│h│
│┌►
││ 
└┘ 

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @BDisp!

@tig tig merged commit 3d16586 into gui-cs:develop Oct 19, 2022
@BDisp BDisp deleted the tabview-minimum-size-improvement branch October 19, 2022 22:21
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants