Skip to content

Fixes 2094. View does not clear it's background.#2104

Merged
tig merged 3 commits intogui-cs:developfrom
BDisp:view-clear-background
Oct 20, 2022
Merged

Fixes 2094. View does not clear it's background.#2104
tig merged 3 commits intogui-cs:developfrom
BDisp:view-clear-background

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Oct 19, 2022

Fixes #2094 - Only the public class views that doesn't overridden the Redraw method is allowed to clear in the virtual View.Redraw method.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View does not clear it's background

2 participants