Simplify MakePrintable by using AND and avoiding converting to string#2101
Simplify MakePrintable by using AND and avoiding converting to string#2101tig merged 5 commits intogui-cs:developfrom pavkam:cleanup_3
Conversation
tig
left a comment
There was a problem hiding this comment.
Can you please provide a unit test that helps ensure this won't cause a regression?
I really appreciate your attention to detail and am excited to have you helping!
|
@tig -- added two parameterized tests |
tig
left a comment
There was a problem hiding this comment.
Before I accept this, I'd like confirmation that this change has been thoroughly tested on Windows, Linux, and the Mac.
I don't fully understand the code paths/scenarios involved where this method is used and am nervous about introducing a regression in an area where we have really poor unit testing (all drivers).
It's a straightforward method. Unit tests cover all scenarios that would be there. I don't think deeper testing is needed for this particular change. |
I confirm that the method is common for all drivers and this is a short way to get the hexadecimal from the rune which is well written. Thanks @pavkam. |
This PR simplifies MakePrintable by using simpler bitwise OR instead of string manipulation.
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)