Skip to content

Fixes #2064. Make Application.MouseGrabView public; allow views who use it some control#2065

Merged
tig merged 2 commits intogui-cs:developfrom
BDisp:mouseGrabView-track-feature
Sep 26, 2022
Merged

Fixes #2064. Make Application.MouseGrabView public; allow views who use it some control#2065
tig merged 2 commits intogui-cs:developfrom
BDisp:mouseGrabView-track-feature

Conversation

@BDisp
Copy link
Copy Markdown
Collaborator

@BDisp BDisp commented Sep 24, 2022

Fixes #2064 - This is useful for a grabbed view that is being grabbed to another view to be notified and thus taking some necessary action.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Copy Markdown
Member

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tig tig changed the title Fixes #2064. mouseGrabView must have a track to allow the views who use it having some control. Fixes #2064. Make Application.MouseGrabView public; allow views who use it some control Sep 26, 2022
@tig tig merged commit 32e7b63 into gui-cs:develop Sep 26, 2022
@BDisp BDisp deleted the mouseGrabView-track-feature branch September 26, 2022 18:05
This was referenced Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mouseGrabView must have a track to allow the views who use it having some control.

2 participants