-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TopLevels with Modal == false
don't receive an event indicating their container is Loaded/Ready
#1883
Comments
Because they are added as a superview's subview, so the |
Sorry @BDisp , but I'm not following what you are saying. I think you are just stating why it is this Issue exists. I have tested my proposed fix (see above) and it works as expected, alleviating the need for me to set the first step manually in the In the Make sense? |
I think your fix to the |
Fixes #1883. Child TopLevel's now get Loaded/Ready events
…hild Toplevel views.
* Fixes #1861. Border Title property is preferable than the Text. * Fixes #1866. Bug when scrolling text and type in a TextView. (#1868) * Some fixes for the WebConsole support. (#1865) * Invoking NotifyStopRunState for all situations. * Added Clicked property to support web console. * Changing to MoveDown to stay always visible. * Fixes #1849. Wizard as non-popup is broken (#1853) * trying to make it work * Fixes #1849. Wizard as non-modal doesn't work * Fixes #1855. Window and Frame content view without the margin frame. * Fixing layout of non-modal * WizardSTep is now a FrameView * Now use Modal = false to set visual style automatically * Removed Controls as an explicit construct. Now just Add to WizardStep Co-authored-by: BDisp <[email protected]> * Update docs with keybindings, global key event and designer (#1869) * Added docs on keybinding and global key event * Added TerminalGuiDesigner to showcases/examples * Regenerated Docs (#1870) * Fixed cancel logic. Title now shows for non-modal. (#1871) * Fixes #1874. API docs on github are broken. (#1875) * Fixes #1874. API docs on github are broken. * Rebuild with docfx 2.59.3.0 version. * Fixes Wizard cancel logic and updates docs (#1878) * Fixed cancel logic. Title now shows for non-modal. * trying to fix docs * trying to fix docs * Fixes #1867. Use Undo and Redo commands with WordWrap enabled. (#1877) * Updated docs; regeneraged docs (#1881) * Added a 'Read Only' to the Editor scenario Format menu. (#1882) * Fixes #1883. Toplevel now propogates Loaded & Ready events to child Toplevel views. * Updated API doc theme. Added Wizard Sample * Tweaked API docs format and content. Fixed build warnings. * Fixes #1889. Docs broken after org move. * Regen API docs * Fixes readme links to API docs * Avoiding breaking change. * Fixes typos. * Passing string.Empty to Title from the default constructor. * Initializes title with string.Empty instead of null. Co-authored-by: Tig Kindel <[email protected]> Co-authored-by: Thomas Nind <[email protected]>
In
Application.cs
And in
Begin()
:Neither
TopLevel.OnReady
orTopLevel.OnLoaded
recurse containedTopLevels
. They should.Something like this:
The text was updated successfully, but these errors were encountered: