Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Add support for full-justifying buttons #1777

Closed
tig opened this issue Jun 8, 2022 · 0 comments · Fixed by #1782
Closed

Dialog: Add support for full-justifying buttons #1777

tig opened this issue Jun 8, 2022 · 0 comments · Fixed by #1782

Comments

@tig
Copy link
Collaborator

tig commented Jun 8, 2022

Wizard (see #124) ideally would support the "Back" and "Next" buttons being fully justified. Wizard will derive from Dialog.

Instead of this:

image

We could have this:
demo

@tig tig added the enhancement label Jun 8, 2022
@tig tig closed this as completed in #1782 Jun 12, 2022
tig added a commit that referenced this issue Jun 12, 2022
* Fixes #1777 - Dialog button justification. Adds unit tests

* Added missing API doc

* Added tests for wide chars

* more tests

* fixed test that broke by adjusting dialog button alignment

* fixed test that broke by adjusting dialog button alignment

* Fixed Dialogs scenario crash re: Parse v TryParse
tig added a commit that referenced this issue Jun 12, 2022
* Initial commit for Wizard

* Fixes #1777 - Dialog button justification. Adds unit tests

* Added missing API doc

* Work in progress

* Added tests for wide chars

* Tests

* more tests

* wip

* fixed test that broke by adjusting dialog button alignment

* fixed test that broke by adjusting dialog button alignment

* Fixed Dialogs scenario crash re: Parse v TryParse

* broke tests. can't figure out how.

* Revert "broke tests. can't figure out how."

This reverts commit f3c5392.

* Fixed unit tests

* Reverted workaround that doesn't work

* Refactor and cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant