Fix: Esc does not clear primary selection when dismissing column block#166
Merged
Conversation
…-caret) The Esc handler called ClearAdditionalCarets() but never cleared the primary row's selection, leaving it highlighted and type-replaceable. Now calls ClearSelection() immediately after, matching the documented "collapse back to the primary caret" behavior. Fixes #143 Agent-Logs-Url: https://github.com/gui-cs/Editor/sessions/9ff74825-e83a-4e36-9a03-dd9317677001 Co-authored-by: tig <585482+tig@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Esc not clearing primary selection in column block
Fix: Esc does not clear primary selection when dismissing column block
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Esc handler called
ClearAdditionalCarets()but never cleared the primary row's selection, leaving it highlighted and type-replaceable after dismissing multi-caret mode.Editor.Keyboard.cs: AddClearSelection()afterClearAdditionalCarets()in the Esc pathEditorColumnSelectionTests.cs: Assert!HasSelectionafter Esc.ans(selection highlight no longer rendered)