Migrate hardcoded keys to KeyBindings using TG 2.1.1-develop.59 Command enum values

[Copilot]

Tab, Shift+Tab, F3, Shift+F3, Ctrl+F, and Ctrl+H were handled via direct key comparison in OnKeyDownNotHandled instead of through Terminal.Gui's KeyBindings system, making them non-configurable.

Changes

• Bumped TerminalGuiVersion from 2.1.0 to 2.1.1-develop.59, which includes the new Command enum values added in gui-cs/Terminal.Gui#5309.
• Added 6 new key bindings in DefaultKeyBindings (Editor.Commands.cs):
  • Command.InsertTab → Tab
  • Command.Unindent → Shift+Tab
  • Command.FindNext → F3
  • Command.FindPrevious → Shift+F3
  • Command.Find → Ctrl+F
  • Command.Replace → Ctrl+H
• Registered AddCommand handlers for all 6 commands with extracted helper methods.
• Removed hardcoded key checks from OnKeyDownNotHandled in Editor.Keyboard.cs — the direct key comparisons for Tab, Shift+Tab, F3, Shift+F3, Ctrl+F, and Ctrl+H are replaced by proper KeyBindings entries.
• Tab/Shift+Tab reclaim logic updated — still removes the framework's focus-cycling bindings after ApplyKeyBindings, but now re-adds them bound to Command.InsertTab / Command.Unindent.
• Added 20 integration tests in EditorKeyBindingTests.cs covering DefaultKeyBindings registration, InvokeCommand behavior (including ReadOnly guards), and key-to-command wire-up for all 6 migrated bindings.

All six keys are now user-configurable through the DefaultKeyBindings dictionary, consistent with how every other editor key binding works.

[tig]

@copilot read the constitution regarding this being part of TG. We don't work around TG limits like missing command enum values. We file Issues against TG so things get fixed right.

[tig]

@copilot read the constitution regarding this being part of TG. We don't work around TG limits like missing command enum values. We file Issues against TG so things get fixed right.

[Copilot]

@copilot read the constitution regarding this being part of TG. We don't work around TG limits like missing command enum values. We file Issues against TG so things get fixed right.

Reverted in e671ac1. All custom (Command)1000–1005 casts are removed; the original OnKeyDownNotHandled key handling is restored. A Terminal.Gui issue should be filed requesting proper Command enum values for these editor operations (InsertTab, Unindent, FindNext, FindPrevious, Find, Replace) so this can be done properly upstream.

@copilot read the constitution regarding this being part of TG. We don't work around TG limits like missing command enum values. We file Issues against TG so things get fixed right.

Addressed in e671ac1 — same revert as above, restoring original key handling and removing all custom Command casts.

[Copilot]

@copilot read the constitution regarding this being part of TG. We don't work around TG limits like missing command enum values. We file Issues against TG so things get fixed right.

Reverted the custom Command enum workaround in e671ac1. The keys (Tab, Shift+Tab, F3, Shift+F3, Ctrl+F, Ctrl+H) are back in OnKeyDownNotHandled. Once Terminal.Gui adds the needed command enum values (InsertTab, Unindent, FindNext, FindPrevious, Find, Replace), we can migrate these to the KeyBindings system properly.

@copilot read the constitution regarding this being part of TG. We don't work around TG limits like missing command enum values. We file Issues against TG so things get fixed right.

Reverted in e671ac1 — no more custom (Command)1000 casts. The original OnKeyDownNotHandled approach is restored. An issue should be filed against Terminal.Gui to add the missing command enum values.

[tig]

@copilot you file the issue on tg

[Copilot]

@copilot you file the issue on tg

I'm unable to file issues on other repositories — I can only make changes within this repo's PR. Could you or another maintainer file the issue on gui-cs/Terminal.Gui requesting the following Command enum additions?

• InsertTab — insert a tab / indent selection
• Unindent — remove one indentation level
• FindNext — move to next search match
• FindPrevious — move to previous search match
• Find — open Find UI
• Replace — open Replace UI

Once those land in TG, the keys currently in OnKeyDownNotHandled can be migrated to the KeyBindings system properly.

[tig]

@copilot see gui-cs/Terminal.Gui#5309 - it's been merged. you might have to wait for nuget to publish.

[Copilot]

@copilot see gui-cs/Terminal.Gui#5309 - it's been merged. you might have to wait for nuget to publish.

Checked — the latest available NuGet package (2.1.1-develop.56) doesn't include the new Command values yet. The PR is merged but a new package build hasn't been published. Once a new 2.1.1-develop.* version ships with Command.InsertTab / Unindent / Find / FindNext / FindPrevious / Replace, I can bump TerminalGuiVersion and migrate the keys from OnKeyDownNotHandled to KeyBindings.

[tig]

@copilot .59 is now published.

[Copilot]

@copilot .59 is now published.

Bumped TerminalGuiVersion to 2.1.1-develop.59 and migrated all 6 keys from OnKeyDownNotHandled to KeyBindings using the proper Command enum values in 7bfe263. Tab, Shift+Tab, F3, Shift+F3, Ctrl+F, and Ctrl+H are now configurable through DefaultKeyBindings.

[tig]

@copilot I don't see any new tests. Is this all thourogly tested?

[Copilot]

@copilot I don't see any new tests. Is this all thourogly tested?

Added 20 integration tests in EditorKeyBindingTests.cs (commit 6f9910f):

• 6 tests verify DefaultKeyBindings contains all new commands
• 6 tests verify InvokeCommand produces correct behavior (InsertTab inserts, Unindent removes whitespace, FindNext/FindPrevious select matches, Find/Replace raise events)
• 2 tests verify ReadOnly guards for InsertTab and Unindent
• 6 tests verify key-to-command wire-up via KeyBindings.GetCommands

Combined with the pre-existing tests in EditorTabTests (7 tests for Tab/Shift+Tab via key injection), EditorSearchHitTests (4 tests for F3/Shift+F3/Ctrl+F/Ctrl+H via key injection), and EditorReadOnlyTests (Tab/ShiftTab read-only guards), all six migrated bindings have thorough coverage.