Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise .cjs files as containing jsx #45

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Recognise .cjs files as containing jsx #45

merged 1 commit into from
Jan 6, 2020

Conversation

BPScott
Copy link
Contributor

@BPScott BPScott commented Jan 4, 2020

.cjs is a new extension that node uses that explicitly forces it to use commonjs modules (compared to mjs which forces the use of ecmascript modules). Previously .cjs files weren't recognised as containing JSX

This should fix stylelint/vscode-stylelint#34.

I'm not sure what the "extensions" list in package.json is for but it mentioned mjs so I'm adding a mention of cjs there too.

@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #45   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          13     13           
  Lines         283    283           
=====================================
  Hits          283    283
Impacted Files Coverage Δ
get-lang.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5842fb9...6376960. Read the comment docs.

@gucong3000 gucong3000 merged commit 0bca5a4 into gucong3000:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stylelint lint Commonjs JavaScript file (.cjs file)
2 participants