Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Orbot via always-on VPN #1041

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

t-m-w
Copy link
Contributor

@t-m-w t-m-w commented Dec 11, 2023

This resolves issue #1007 and is an updated version of #828 that was merged into v16_maintenance.


When the system tries to start Orbot as a result of the always-on VPN setting, automatically connect to Tor as a VPN without requiring additional user intervention. In this case, the system will also start Orbot on boot regardless of the "Start Orbot on Boot" setting. This support is especially important for scenarios where Orbot is bundled with the OS in always-on mode.

Test: Manual: Install Orbot and start the VPN. In the system settings, set Orbot as an always-on VPN. Clear storage for Orbot, and optionally turn on Notifiations. Reboot the device, or turn the always-on VPN setting off and on again. In either case, Orbot automatically connects and is available for use.

When the system tries to start Orbot as a result of the always-on VPN
setting, automatically connect to Tor as a VPN without requiring
additional user intervention. In this case, the system will also start
Orbot on boot regardless of the "Start Orbot on Boot" setting.
This support is especially important for scenarios where Orbot is
bundled with the OS in always-on mode.

Test: Manual: Install Orbot and start the VPN. In the system settings,
set Orbot as an always-on VPN. Clear storage for Orbot, and optionally
turn on Notifiations. Reboot the device, or turn the always-on VPN
setting off and on again. In either case, Orbot automatically connects
and is available for use.
@bitmold
Copy link
Collaborator

bitmold commented Dec 18, 2023

Looks great, thank you

@bitmold bitmold closed this Dec 18, 2023
@bitmold bitmold reopened this Dec 18, 2023
@bitmold bitmold merged commit 27eaf19 into guardianproject:master Dec 18, 2023
1 check failed
bitmold added a commit that referenced this pull request Dec 18, 2023
bitmold added a commit that referenced this pull request Dec 18, 2023
…tem #1041

Not sure why'd you get a null intent anyway, but this way we avoid a NPE...
@t-m-w
Copy link
Contributor Author

t-m-w commented Dec 20, 2023

Thanks so much for the fixes and the merge!

bitmold added a commit that referenced this pull request Jan 25, 2024
This is because the KindnessFragment never specified that the Intents it sends to OrbotService
weren't system intents... Fixed this here.

Also made global extension function for things like putNotSystem() so each fragment, activity, etc
doesn't need to locally define that extension function...
bitmold added a commit that referenced this pull request Jan 25, 2024
bitmold added a commit that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants