Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Implicitly using the default locale is a common source of bugs: Use toUpperCase(Locale) instead #588

Closed
n8fr8 opened this issue Jan 27, 2022 · 0 comments
Assignees

Comments

@n8fr8
Copy link
Member

n8fr8 commented Jan 27, 2022

Wrote HTML report to file:///builds/guardianproject/orbot/orbotservice/build/reports/lint-results-debug.html
Lint found 1 error and 99 warnings. First failure:
/builds/guardianproject/orbot/orbotservice/src/main/java/org/torproject/android/service/OrbotRawEventListener.java:113: Error: Implicitly using the default locale is a common source of bugs: Use toUpperCase(Locale) instead. For strings meant to be internal use Locale.ROOT, otherwise Locale.getDefault(). [DefaultLocale]
String countryCode = mService.conn.getInfo("ip-to-country/" + node.ipAddress).toUpperCase();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants