Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onion site backup does not work #523

Closed
TwinkleToes777 opened this issue Sep 2, 2021 · 3 comments
Closed

Onion site backup does not work #523

TwinkleToes777 opened this issue Sep 2, 2021 · 3 comments
Assignees
@bitmold

Comments

@TwinkleToes777
Copy link

whenever I create Onion site backup, it creates empty .zip file of 0 B size. I believe this is caused by that Orbot never asks file storage access permission, I couldn't find any way to give it, I tried with ADB, but it threw error that it has never asked for this permission.

I have tried both the F-Droid version and the latest BETA of Orbot.
@bitmold
Copy link
Collaborator

bitmold commented Sep 23, 2021

I'm looking into this now on all supported versions of Android. What version of Android were you running? I've seen this functionality was working before

@bitmold bitmold self-assigned this Sep 23, 2021
@bitmold
Copy link
Collaborator

bitmold commented Sep 24, 2021

Also were you backing up a v2 or v3 onion service?

@bitmold
Copy link
Collaborator

bitmold commented Sep 24, 2021

This bug was introduced when a fix to a bug that prevented hosting multiple onion services pointing to the same local port was introduced. Fixing it now...

bitmold added a commit that referenced this issue Sep 24, 2021
@bitmold
Fixes #523 Onion Site Backup Bags
eab6ed8 
This bug was introdued when a previous bug fix pertaining to Onion service storage in Orbot was addressed.
The old bug made it such that multiple onion services could be hosted that pointed to the same local port on the device.
This previous bug fix broke the backup logic for v2 and v3 onion services, which is fixed here.
syphyr pushed a commit to syphyr/orbot that referenced this issue Sep 24, 2021
@bitmold @syphyr
Fixes guardianproject#523 Onion Site Backup Bags
8e7aa15 
This bug was introdued when a previous bug fix pertaining to Onion service storage in Orbot was addressed.
The old bug made it such that multiple onion services could be hosted that pointed to the same local port on the device.
This previous bug fix broke the backup logic for v2 and v3 onion services, which is fixed here.
bitmold added a commit that referenced this issue Sep 28, 2021
@bitmold
Fixes #523 Onion Site Backup Bags
fcfcc54 
This bug was introdued when a previous bug fix pertaining to Onion service storage in Orbot was addressed.
The old bug made it such that multiple onion services could be hosted that pointed to the same local port on the device.
This previous bug fix broke the backup logic for v2 and v3 onion services, which is fixed here.
syphyr pushed a commit to syphyr/orbot that referenced this issue Sep 28, 2021
@bitmold @syphyr
Fixes guardianproject#523 Onion Site Backup Bags
01cf46d 
This bug was introdued when a previous bug fix pertaining to Onion service storage in Orbot was addressed.
The old bug made it such that multiple onion services could be hosted that pointed to the same local port on the device.
This previous bug fix broke the backup logic for v2 and v3 onion services, which is fixed here.
@n8fr8 n8fr8 closed this as completed in 5465fff Oct 12, 2021
n8fr8 added a commit that referenced this issue Oct 12, 2021
@n8fr8
Merge pull request #527 from guardianproject/fix_523_onionbackup
e815bc0 
Fixes #523 Onion Site Backup Bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bitmold bitmold

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitmold @TwinkleToes777