This repository was archived by the owner on Jul 26, 2022. It is now read-only.
Upgrade to @guardian/cdk 8.0.1 #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobwinch
commented
Apr 9, 2021
| @@ -51,6 +54,7 @@ export class CdkStack extends GuStack { | |||
| }, | |||
| schedule: Schedule.rate(lambdaFrequency), | |||
| monitoringConfiguration: { | |||
| alarmName: `High error % from ${app}-${this.stage}`, | |||
There was a problem hiding this comment.
This resource is being replaced (the logical id is changing). AWS attempts to create a new alarm before deleting the old one, so we need to use a different name or this operation fails (you cannot have 2 alarms with the same name). As it happens the new name is a bit better anyway 😄
akash1810
approved these changes
Apr 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades to
@guardian/cdk8.0.1, primarily to pull in the alarm improvements from guardian/cdk#404.How to test
I've confirmed that this change can be deployed successfully.