Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #6663

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Remove unused dependencies #6663

merged 4 commits into from
Jan 6, 2025

Conversation

andrewHEguardian
Copy link
Contributor

@andrewHEguardian andrewHEguardian commented Dec 30, 2024

What are you doing in this PR?

Running yarn knip --include dependencies to try find unused dependences

Trello Card

Why are you doing this?

https://knip.dev/typescript/unused-dependencies#why-are-unused-dependencies-a-problem

Copy link
Contributor

github-actions bot commented Dec 30, 2024

Size Change: +1.39 kB (+0.06%)

Total Size: 2.23 MB

ℹ️ View Unchanged
Filename Size Change
./public/compiled-assets/javascripts/[countryGroupId]/events/router.js 90.1 kB +79 B (+0.09%)
./public/compiled-assets/javascripts/[countryGroupId]/router.js 265 kB +85 B (+0.03%)
./public/compiled-assets/javascripts/ausMomentMap.js 108 kB +81 B (+0.08%)
./public/compiled-assets/javascripts/contributionsRedirectStyles.js 20 B 0 B
./public/compiled-assets/javascripts/digitalSubscriptionLandingPage.js 235 kB +95 B (+0.04%)
./public/compiled-assets/javascripts/downForMaintenancePage.js 70.5 kB +80 B (+0.11%)
./public/compiled-assets/javascripts/error404Page.js 70.4 kB +79 B (+0.11%)
./public/compiled-assets/javascripts/error500Page.js 70.4 kB +79 B (+0.11%)
./public/compiled-assets/javascripts/favicons.js 617 B 0 B
./public/compiled-assets/javascripts/paperSubscriptionCheckoutPage.js 175 kB +116 B (+0.07%)
./public/compiled-assets/javascripts/paperSubscriptionLandingPage.js 87.3 kB +90 B (+0.1%)
./public/compiled-assets/javascripts/payPalErrorPage.js 68.7 kB +80 B (+0.12%)
./public/compiled-assets/javascripts/payPalErrorPageStyles.js 20 B 0 B
./public/compiled-assets/javascripts/promotionTerms.js 73.4 kB +84 B (+0.11%)
./public/compiled-assets/javascripts/subscriptionsLandingPage.js 72.7 kB +83 B (+0.11%)
./public/compiled-assets/javascripts/subscriptionsRedemptionPage.js 127 kB +82 B (+0.06%)
./public/compiled-assets/javascripts/supporterPlusLandingPage.js 307 kB +80 B (+0.03%)
./public/compiled-assets/javascripts/unsupportedBrowserStyles.js 20 B 0 B
./public/compiled-assets/javascripts/weeklySubscriptionCheckoutPage.js 171 kB +108 B (+0.06%)
./public/compiled-assets/javascripts/weeklySubscriptionLandingPage.js 87.1 kB +87 B (+0.1%)
./public/compiled-assets/webpack/136.js 2.17 kB 0 B
./public/compiled-assets/webpack/187.js 21.4 kB 0 B
./public/compiled-assets/webpack/344.js 2.01 kB 0 B
./public/compiled-assets/webpack/643.js 22.4 kB 0 B
./public/compiled-assets/webpack/706.js 107 kB 0 B

compressed-size-action

@andrewHEguardian andrewHEguardian marked this pull request as ready for review December 30, 2024 15:22
Copy link
Member

@tjmw tjmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This is great. And the fact that the UI tests/storybook build checks look good should give us confidence that there aren't any unintended side effects.

Copy link
Contributor

@paul-daniel-dempsey paul-daniel-dempsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@andrewHEguardian andrewHEguardian merged commit 8094b2b into main Jan 6, 2025
15 checks passed
@andrewHEguardian andrewHEguardian deleted the ahe/unused-dependencies branch January 6, 2025 12:09
@prout-bot
Copy link

Seen on PROD (merged by @andrewHEguardian 9 minutes and 52 seconds ago)

Sentry Release: support-client-side, support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants