Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Java recommendations #87

Merged
merged 1 commit into from
May 12, 2022
Merged

Update Java recommendations #87

merged 1 commit into from
May 12, 2022

Conversation

nicl
Copy link
Contributor

@nicl nicl commented May 9, 2022

...to recommend Corretto as the distribution and 11 or newer LTS
versions.

A longer write-up of the rationale can be found here:

https://docs.google.com/document/d/1ZR-YnaXCT5_gLVmTCeGs0mWd3KPaAozPjQK8uUzHZ9w/edit?usp=sharing

...to recommend Corretto as the distribution and 11 or newer LTS
versions.

A longer write-up of the rationale can be found here:

https://docs.google.com/document/d/1ZR-YnaXCT5_gLVmTCeGs0mWd3KPaAozPjQK8uUzHZ9w/edit?usp=sharing
* Avoid dependency injection in general.

[Dependency injection](https://en.wikipedia.org/wiki/Dependency_injection) is a software design pattern that implements [inversion of control](https://en.wikipedia.org/wiki/Inversion_of_control) between a `client` and a `service` for resolving dependencies. The term `injection` refers to a third party (named `the injector`) which is responsible for constructing the services and injecting them into the client. Usual `injectors`are dependency injection frameworks such as `guice`, `dagger`, `macwire`, `spring`.
* Run on a Corretto LTS version of Java, no lower than Java 11. At the time of writing this means Corretto 11 or 17. For tips on upgrading from Java 8, see [here](https://docs.google.com/document/d/1ZR-YnaXCT5_gLVmTCeGs0mWd3KPaAozPjQK8uUzHZ9w/edit?usp=sharing).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth placing this GDoc in GitHub too? Maybe as a wiki if it doesn't naturally fit within this repo?

Copy link
Contributor Author

@nicl nicl May 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the benefit here to be honest. What was your thinking? /recommendations seems to be for a concise statement of best practice. Google Docs feels better suited to lengthy guides as they are easier to collaborate on and provide easier support for rich document features (TOC, images, etc.).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been bitten in the past where GitHub referred to a GDoc that no longer existed because the owner had left and didn't change ownership of it. That's harder to do with VCS.

Not a blocker.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that is horrible! The doc is in the shared drive at least, so hopefully should be safe for a while.

@nicl nicl merged commit 835519e into main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants