Add notes on Internal vs Private visibility #179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GitHub introduced internal repositories, it's unclear whether
Internal
orPrivate
is the best choice for new repositories.It's also unclear what the role of the
@guardian/guardian-developers-read
team is, given the existence of internal repositories.I've added some guidelines indicating:
Internal
overPrivate
@guardian/guardian-developers-write
@guardian/guardian-developers-read
is effectively deprecated given the preference for internal repositories