Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on Internal vs Private visibility #179

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

joelochlann
Copy link
Member

Since GitHub introduced internal repositories, it's unclear whether Internal or Private is the best choice for new repositories.

It's also unclear what the role of the @guardian/guardian-developers-read team is, given the existence of internal repositories.

I've added some guidelines indicating:

  1. a preference for Internal over Private
  2. a preference for also granting write permissions to @guardian/guardian-developers-write
  3. that @guardian/guardian-developers-read is effectively deprecated given the preference for internal repositories

Copy link
Contributor

@adamnfish adamnfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me, thank you!

@mchv mchv merged commit d7ff620 into main Sep 17, 2024
3 checks passed
@mchv mchv deleted the js-recommendations-on-internal-visibility branch September 17, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants