Improve memory usage with streaming of AWS requests#10
Merged
Conversation
AWS SDK v2.17.97 includes aws/aws-sdk-java-v2#2848, which lowers memory consumption by streaming request data, rather than loading the entire request into memory before sending it, which can make a large difference to consumption of memory when uploading large files to S3. In the case of the `geoip-db-refresher`, it's actually economical to run with _more_ RAM than we need (we're billed for fewer GB-seconds when specifying a `MemorySize` of 1536MB than 1024MB, as AWS Lambdas are given more CPU to match increased memory) so this is no longer a serious issue for the 134MB file uploaded here! See also: * #7 * #8 * 1de50ef * https://aws.amazon.com/lambda/pricing/ * https://docs.aws.amazon.com/lambda/latest/dg/configuration-function-common.html#configuration-memory-console
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWS SDK v2.17.97 includes aws/aws-sdk-java-v2#2848, which lowers memory consumption by streaming request data, rather than loading the entire request into memory before sending it, which can make a large difference to consumption of memory when uploading large files to S3.
In the case of the
geoip-db-refresher, it's actually economical to run with more RAM than we need (we're billed for fewer GB-seconds when specifying aMemorySizeof 1536MB than 1024MB, as AWS Lambdas are given more CPU to match increased memory) so this is no longer a serious issue for the 134MB file uploaded here!See also: