Merge pull request #3030 from guardian/mm/fix-signin-okta-classic-flag

Fix | `useOktaClassic` query param on sign in page

src/client/pages/SignInPage.tsx

@@ -30,15 +30,30 @@ export const SignInPage = ({
 	// we use the encryptedEmail parameter to pre-fill the email field, but then want to remove it from the url
 	useRemoveEncryptedEmailParam();
 
+	// determines if the passcode view of the sign in page should be shown
 	const usePasscodeSignIn: boolean = (() => {
+		// if the forcePasswordPage flag is set, we should always show the password view
+		// for example when the user clicks "sign in with password instead"
 		if (forcePasswordPage) {
 			return false;
 		}
 
+		// if the useOktaClassic flag is set, we should always show the password view
+		// to maintain the existing behaviour
+		if (queryParams.useOktaClassic) {
+			return false;
+		}
+
+		// if the user is in the PasscodeSignInTest variant, we should show the passcode view
+		// to test the new sign in flow
+		// eventually this will be removed and the passcode view will be shown by default
 		if (ABTestAPI.isUserInVariant('PasscodeSignInTest', 'variant')) {
 			return true;
 		}
 
+		// if the usePasscodeSignIn query param is set, we should show the passcode view
+		// this is used for testing the new sign in flow
+		// eventually this will be removed and the passcode view will be shown by default
 		return !!queryParams.usePasscodeSignIn;
 	})();