-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add US-only option in Collection #1748
Open
Divs-B
wants to merge
25
commits into
main
Choose a base branch
from
db/add-us-only-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+3,702
−3,125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of US-only option
… for US option. wired this via controller for routes.
…spot the problem.
fredex42
force-pushed
the
db/add-us-only-option
branch
from
January 22, 2025 17:30
97dabf1
to
b302b74
Compare
…dpoint and few ui tweak to adjust menu item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by @fredex42 (Thanks for help in Backend and DB wiring!)
What's changed?
We are now moving towards country specific curation of data,
We want to try for US first to provide much more in-depth use of Feast App for US users.
We are going to put
US only
option to Container(Collection) level to help Editorial users to select option if they want to mark it for only to display in US.(Note: As we might need to get other devs on Fronts tool and UX help to confirm button's look and feel so its style and appearance are subject to change.)
Screen.Recording.2025-01-20.at.16.16.56.mov
This wiring will help in supplying the data to Database and to backend for our Apps team to use at the end.
Checklist
General
Client