Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add US-only option in Collection #1748

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add US-only option in Collection #1748

wants to merge 25 commits into from

Conversation

Divs-B
Copy link
Contributor

@Divs-B Divs-B commented Jan 16, 2025

Co-authored by @fredex42 (Thanks for help in Backend and DB wiring!)

What's changed?

We are now moving towards country specific curation of data,
We want to try for US first to provide much more in-depth use of Feast App for US users.
We are going to put US only option to Container(Collection) level to help Editorial users to select option if they want to mark it for only to display in US.

  1. UI section: The change will have dropdown menu now from headlessui/react library, this will only be for Feast Editions at the moment.
    (Note: As we might need to get other devs on Fronts tool and UX help to confirm button's look and feel so its style and appearance are subject to change.)
Screen.Recording.2025-01-20.at.16.16.56.mov
  1. Backend and DB wiring section: Thanks @fredex42 for help in wiring this end to end (thanks to @jonathonherbert too for confirming on ways to achieve this in the code).
    This wiring will help in supplying the data to Database and to backend for our Apps team to use at the end.

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@Divs-B Divs-B requested a review from a team as a code owner January 16, 2025 09:49
@fredex42 fredex42 force-pushed the db/add-us-only-option branch from 97dabf1 to b302b74 Compare January 22, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants